Add Support for S3 Signature Version#5448
Closed
seandonohoo wants to merge 1 commit intoopsmill:developfrom
seandonohoo:S3SignatureVersion
Closed
Add Support for S3 Signature Version#5448seandonohoo wants to merge 1 commit intoopsmill:developfrom seandonohoo:S3SignatureVersion
seandonohoo wants to merge 1 commit intoopsmill:developfrom
seandonohoo:S3SignatureVersion
Conversation
|
|
|
seandonohoo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
CodSpeed Performance ReportMerging #5448 will not alter performanceComparing Summary
|
Contributor
Author
|
Closing no longer needed 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will have to wait until fastapi_storages PR is approved smithyhq/fastapi-storages#57
Currently fastapi_storages has no support for older S3 signature versions(Ie Version 2) but the upstream Boto python SDK does.
This will allow old signature versions to be supported with S3 storage.
Examples: